fix(HikariCP:6.0.0): resolve test failures #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vjovanov please review this pull request when possible as we are planning to have a new release of reachability metadata (+Native Build Tools) soon. |
- Added GraalVM native agent configuration with conditional mode - Included - Updated to include and - Regenerated GraalVM metadata
erguiti-imane
force-pushed
the
HikariCP/fix-6.0.0
branch
from
6660e67 to
3801954
Compare
|
@mhalbritter can you please review this PR as you added initial tests for HikariCP? |
mhalbritter
reviewed
May 28, 2025
| @@ -0,0 +1,5 @@ | |||
| [ | |||
| { | |||
| "name": "jdk.internal.loader.ClassLoaders$PlatformClassLoader" | |||
There was a problem hiding this comment.
I wonder why that is needed? Does the test pass without that file?
| @@ -0,0 +1,18 @@ | |||
| [ | |||
| { | |||
| "name": "com.zaxxer.hikari.HikariConfig", | |||
There was a problem hiding this comment.
I can understand why com.zaxxer.hikaricp.test.driver.CustomDriver has to registered for reflection in tests only. But why is com.zaxxer.hikari.HikariConfig in there? Shouldn't that be in the metadata/com.zaxxer/HikariCP/6.0.0/reflect-config.json file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
user-code-filter.jsonreflect-config.jsonto includeHikariConfig#getCredentialsandHikariConfig#getExceptionOverrideChecklist before merging